]> git.baikalelectronics.ru Git - kernel.git/commit
drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()
authorYuan Can <yuancan@huawei.com>
Fri, 4 Nov 2022 06:45:12 +0000 (06:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jan 2023 10:11:57 +0000 (11:11 +0100)
commitb59b39835cd9f6ee0c1fe110c3d3dbaf990cbed8
tree000e33d22d4fd020ee50c5e9e284f645c51e93df
parent4e72a50b91ce674492d9420bc71e6cce70b95594
drm/ingenic: Fix missing platform_driver_unregister() call in ingenic_drm_init()

commit cd5d53d03e73a41069d8025a1676a3f8b5e666e4 upstream.

A problem about modprobe ingenic-drm failed is triggered with the following
log given:

 [  303.561088] Error: Driver 'ingenic-ipu' is already registered, aborting...
 modprobe: ERROR: could not insert 'ingenic_drm': Device or resource busy

The reason is that ingenic_drm_init() returns platform_driver_register()
directly without checking its return value, if platform_driver_register()
failed, it returns without unregistering ingenic_ipu_driver_ptr, resulting
the ingenic-drm can never be installed later.
A simple call graph is shown as below:

 ingenic_drm_init()
   platform_driver_register() # ingenic_ipu_driver_ptr are registered
   platform_driver_register()
     driver_register()
       bus_add_driver()
         priv = kzalloc(...) # OOM happened
   # return without unregister ingenic_ipu_driver_ptr

Fixing this problem by checking the return value of
platform_driver_register() and do platform_unregister_drivers() if
error happened.

Fixes: 1e79bb3bcc65 ("drm/ingenic: Add support for the IPU")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20221104064512.8569-1-yuancan@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/ingenic/ingenic-drm-drv.c