]> git.baikalelectronics.ru Git - kernel.git/commit
mm: userfaultfd: fix UFFDIO_CONTINUE on fallocated shmem pages
authorAxel Rasmussen <axelrasmussen@google.com>
Fri, 10 Jun 2022 17:38:12 +0000 (10:38 -0700)
committerakpm <akpm@linux-foundation.org>
Sun, 3 Jul 2022 22:42:32 +0000 (15:42 -0700)
commitb5829a1f1dc45482bd7d4ccc471c340bc9994d22
tree9aa244594be59eeb038b115708db562bc3d2b114
parent95bff9fd66ecd812d590c69387965cb20664fd49
mm: userfaultfd: fix UFFDIO_CONTINUE on fallocated shmem pages

When fallocate() is used on a shmem file, the pages we allocate can end up
with !PageUptodate.

Since UFFDIO_CONTINUE tries to find the existing page the user wants to
map with SGP_READ, we would fail to find such a page, since
shmem_getpage_gfp returns with a "NULL" pagep for SGP_READ if it discovers
!PageUptodate.  As a result, UFFDIO_CONTINUE returns -EFAULT, as it would
do if the page wasn't found in the page cache at all.

This isn't the intended behavior.  UFFDIO_CONTINUE is just trying to find
if a page exists, and doesn't care whether it still needs to be cleared or
not.  So, instead of SGP_READ, pass in SGP_NOALLOC.  This is the same,
except for one critical difference: in the !PageUptodate case, SGP_NOALLOC
will clear the page and then return it.  With this change, UFFDIO_CONTINUE
works properly (succeeds) on a shmem file which has been fallocated, but
otherwise not modified.

Link: https://lkml.kernel.org/r/20220610173812.1768919-1-axelrasmussen@google.com
Fixes: 0c548f86fd7b ("userfaultfd/shmem: support UFFDIO_CONTINUE for shmem")
Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
Acked-by: Peter Xu <peterx@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/userfaultfd.c