]> git.baikalelectronics.ru Git - kernel.git/commit
sysctl: Fix data races in proc_dointvec_minmax().
authorKuniyuki Iwashima <kuniyu@amazon.com>
Wed, 6 Jul 2022 23:39:54 +0000 (16:39 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Jul 2022 19:24:20 +0000 (21:24 +0200)
commitb4f5e23bd71f9bcfb3c73d049f706f2631fc770d
treef6ceca883c3ec816d7ccda598de3499528919836
parent6b8bb022793e16c54633dafe18cbedf32e29fd70
sysctl: Fix data races in proc_dointvec_minmax().

[ Upstream commit 8d17890c7cc4fe71d8b3e38411f748bfcce620e9 ]

A sysctl variable is accessed concurrently, and there is always a chance
of data-race.  So, all readers and writers need some basic protection to
avoid load/store-tearing.

This patch changes proc_dointvec_minmax() to use READ_ONCE() and
WRITE_ONCE() internally to fix data-races on the sysctl side.  For now,
proc_dointvec_minmax() itself is tolerant to a data-race, but we still
need to add annotations on the other subsystem's side.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/sysctl.c