]> git.baikalelectronics.ru Git - kernel.git/commit
f2fs: fix the panic in do_checkpoint()
authorSahitya Tummala <stummala@codeaurora.org>
Tue, 18 Feb 2020 03:49:07 +0000 (09:19 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Apr 2020 08:36:28 +0000 (10:36 +0200)
commitb4e90c8ce491dd52dc223d393417b9ed45310109
tree5570f167777b2ecef5dc6b1f91fffeadcf443432
parent19b4ec6baf05f2975aea1dadd2f934cc256775b0
f2fs: fix the panic in do_checkpoint()

[ Upstream commit d8522f0e687c58666a2dde1bd3dd39e071f9adf5 ]

There could be a scenario where f2fs_sync_meta_pages() will not
ensure that all F2FS_DIRTY_META pages are submitted for IO. Thus,
resulting in the below panic in do_checkpoint() -

f2fs_bug_on(sbi, get_pages(sbi, F2FS_DIRTY_META) &&
!f2fs_cp_error(sbi));

This can happen in a low-memory condition, where shrinker could
also be doing the writepage operation (stack shown below)
at the same time when checkpoint is running on another core.

schedule
down_write
f2fs_submit_page_write -> by this time, this page in page cache is tagged
as PAGECACHE_TAG_WRITEBACK and PAGECACHE_TAG_DIRTY
is cleared, due to which f2fs_sync_meta_pages()
cannot sync this page in do_checkpoint() path.
f2fs_do_write_meta_page
__f2fs_write_meta_page
f2fs_write_meta_page
shrink_page_list
shrink_inactive_list
shrink_node_memcg
shrink_node
kswapd

Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/f2fs/checkpoint.c
fs/f2fs/f2fs.h
fs/f2fs/super.c