]> git.baikalelectronics.ru Git - kernel.git/commit
rtlwifi: rtl8723ae: Fix missing break in switch statement
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 16 Apr 2019 15:17:22 +0000 (10:17 -0500)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 25 Apr 2019 16:55:48 +0000 (19:55 +0300)
commitb33a89443c32035a2a71bda323dd967918474be2
tree91b995321836dd7f03e25592a507931a997149eb
parent2e17d4f2fe57bd76541557c8d32ed60855086232
rtlwifi: rtl8723ae: Fix missing break in switch statement

Add missing break statement in order to prevent the code from falling
through to case 0x1025, and erroneously setting rtlhal->oem_id to
RT_CID_819X_ACER when rtlefuse->eeprom_svid is equal to 0x10EC and
none of the cases in switch (rtlefuse->eeprom_smid) match.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: 5ad44bd50f34 ("rtlwifi: rtl8723ae: Clean up the hardware info routine")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c