]> git.baikalelectronics.ru Git - kernel.git/commit
net: encx24j600: Add parentheses to fix precedence
authorValentina Goncharenko <goncharenko.vp@ispras.ru>
Thu, 1 Dec 2022 17:34:07 +0000 (20:34 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Dec 2022 10:30:45 +0000 (11:30 +0100)
commitb2e6c4d578b765465b25af16d88ee2e316093bdc
treeddba8065df932babe839948729f863cb685ad4ef
parent74a8fe8a4913644bd67707acb0e3c0acfd31ef1c
net: encx24j600: Add parentheses to fix precedence

[ Upstream commit 3bd5565dd1f70c3280614f4a9a35925966d80756 ]

In functions regmap_encx24j600_phy_reg_read() and
regmap_encx24j600_phy_reg_write() in the conditions of the waiting
cycles for filling the variable 'ret' it is necessary to add parentheses
to prevent wrong assignment due to logical operations precedence.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 74badaf8836f ("net: Microchip encx24j600 driver")
Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/microchip/encx24j600-regmap.c