]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: sd: Suppress spurious errors when WRITE SAME is being disabled
authorEwan D. Milne <emilne@redhat.com>
Mon, 7 Dec 2020 22:10:21 +0000 (17:10 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 6 Jan 2021 04:45:51 +0000 (23:45 -0500)
commitb219dd39ce911f5544672fbec799dfc1a2d0ca78
tree4f82d2663c11682b9ea657d2ce3b7a6371613b67
parent665d30d9f38c3a3afca42d9623109464b3f33d21
scsi: sd: Suppress spurious errors when WRITE SAME is being disabled

The block layer code will split a large zeroout request into multiple bios
and if WRITE SAME is disabled because the storage device reports that it
does not support it (or support the length used), we can get an error
message from the block layer despite the setting of RQF_QUIET on the first
request.  This is because more than one request may have already been
submitted.

Fix this by setting RQF_QUIET when BLK_STS_TARGET is returned to fail the
request early, we don't need to log a message because we did not actually
submit the command to the device, and the block layer code will handle the
error by submitting individual write bios.

Link: https://lore.kernel.org/r/20201207221021.28243-1-emilne@redhat.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c