]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl: qcom: sdm845: Enable dual edge errata
authorBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 2 Nov 2021 03:41:15 +0000 (22:41 -0500)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 16 Nov 2021 01:19:15 +0000 (02:19 +0100)
commitb10cfca8266514cbc9908fd2179ed9cd2287bf36
tree8cb2654d847452fbc136fe79d62f099c81c554c8
parentc997f98a1ca374d6efe9b354c09d52613a61bd71
pinctrl: qcom: sdm845: Enable dual edge errata

It has been observed that dual edge triggered wakeirq GPIOs on SDM845
doesn't trigger interrupts on the falling edge.

Enabling wakeirq_dual_edge_errata for SDM845 indicates that the PDC in
SDM845 suffers from the same problem described, and worked around, by
Doug in 'c09111340be3 ("pinctrl: qcom: Handle broken/missing PDC dual
edge IRQs on sc7180")', so enable the workaround for SDM845 as well.

The specific problem seen without this is that gpio-keys does not detect
the falling edge of the LID gpio on the Lenovo Yoga C630 and as such
consistently reports the LID as closed.

Fixes: 063c6ff428fb ("pinctrl/msm: Setup GPIO chip in hierarchy")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Tested-By: Steev Klimaszewski <steev@kali.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20211102034115.1946036-1-bjorn.andersson@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-sdm845.c