]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "serial: max310x: pass return value of spi_register_driver"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:37 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:30:18 +0000 (17:30 +0200)
commitb10bca29cc387083b9d3832cd3195052aa12916c
treecca4477c1854ca20c55dfb0a93e64468a9a4c312
parent7dc1ccb8e7d9995bff426e03cc97da0ff659e32b
Revert "serial: max310x: pass return value of spi_register_driver"

This reverts commit 94bebfc40a2d99d531262b01f986e32e4f4b1854.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

This change did not properly unwind from the error condition, so it was
not correct.

Cc: Kangjie Lu <kjlu@umn.edu>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-11-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/max310x.c