]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (w83792d) Fix NULL pointer dereference by removing unnecessary structure field
authorNadezda Lutovinova <lutovinova@ispras.ru>
Tue, 21 Sep 2021 15:51:52 +0000 (18:51 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Oct 2021 13:42:30 +0000 (15:42 +0200)
commitb102c1fc05b87130c550aff0473bdb5978225f29
tree7ae9b722026f7790a156ea4bd601b1939de31973
parent8f9f79d87aead61e644b68db3f6bd7becc276ade
hwmon: (w83792d) Fix NULL pointer dereference by removing unnecessary structure field

commit 0f36b88173f028e372668ae040ab1a496834d278 upstream.

If driver read val value sufficient for
(val & 0x08) && (!(val & 0x80)) && ((val & 0x7) == ((val >> 4) & 0x7))
from device then Null pointer dereference occurs.
(It is possible if tmp = 0b0xyz1xyz, where same literals mean same numbers)
Also lm75[] does not serve a purpose anymore after switching to
devm_i2c_new_dummy_device() in w83791d_detect_subclients().

The patch fixes possible NULL pointer dereference by removing lm75[].

Found by Linux Driver Verification project (linuxtesting.org).

Cc: stable@vger.kernel.org
Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Link: https://lore.kernel.org/r/20210921155153.28098-2-lutovinova@ispras.ru
[groeck: Dropped unnecessary continuation lines, fixed multipline alignment]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/w83792d.c