]> git.baikalelectronics.ru Git - kernel.git/commit
net: ks8851-ml: Fix 16-bit IO operation
authorMarek Vasut <marex@denx.de>
Sat, 15 Feb 2020 16:54:19 +0000 (17:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Mar 2020 12:00:13 +0000 (13:00 +0100)
commitb0d755e7bbbfca1f04f39ca7afe031e08b040567
tree07b7558c9c780df68b8139b93f66b78d7353a6eb
parent3df38df499a68ca2d74fb8ff9aa1dfce637b7ad9
net: ks8851-ml: Fix 16-bit IO operation

[ Upstream commit e6aaf03eebc02aec3b20394b3d8ece59fce31500 ]

The Micrel KSZ8851-16MLLI datasheet DS00002357B page 12 states that
BE[3:0] signals are active high. This contradicts the measurements
of the behavior of the actual chip, where these signals behave as
active low. For example, to read the CIDER register, the bus must
expose 0xc0c0 during the address phase, which means BE[3:0]=4'b1100.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Petr Stetiar <ynezz@true.cz>
Cc: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/micrel/ks8851_mll.c