]> git.baikalelectronics.ru Git - kernel.git/commit
x86/olpc: fix 'logical not is only applied to the left hand side'
authorAlexander Lobakin <alexandr.lobakin@intel.com>
Fri, 15 Jul 2022 15:15:36 +0000 (17:15 +0200)
committerYury Norov <yury.norov@gmail.com>
Fri, 15 Jul 2022 15:30:16 +0000 (08:30 -0700)
commitb0b99a47d43cbb89bd8c27a243149f07e7767757
tree609e8d5ae2278e9623ee43c7ffe9b4e08cd7657f
parentdba7e5202c743ed54adb8291e1c1250f093a6c45
x86/olpc: fix 'logical not is only applied to the left hand side'

The bitops compile-time optimization series revealed one more
problem in olpc-xo1-sci.c:send_ebook_state(), resulted in GCC
warnings:

arch/x86/platform/olpc/olpc-xo1-sci.c: In function 'send_ebook_state':
arch/x86/platform/olpc/olpc-xo1-sci.c:83:63: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
   83 |         if (!!test_bit(SW_TABLET_MODE, ebook_switch_idev->sw) == state)
      |                                                               ^~
arch/x86/platform/olpc/olpc-xo1-sci.c:83:13: note: add parentheses around left hand side expression to silence this warning

Despite this code working as intended, this redundant double
negation of boolean value, together with comparing to `char`
with no explicit conversion to bool, makes compilers think
the author made some unintentional logical mistakes here.
Make it the other way around and negate the char instead
to silence the warnings.

Fixes: a007a72cb461 ("x86/olpc/xo1/sci: Produce wakeup events for buttons and switches")
Cc: stable@vger.kernel.org # 3.5+
Reported-by: Guenter Roeck <linux@roeck-us.net>
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
arch/x86/platform/olpc/olpc-xo1-sci.c