]> git.baikalelectronics.ru Git - kernel.git/commit
drm/sti: do not remove the drm_bridge that was never added
authorPeter Rosin <peda@axentia.se>
Mon, 6 Aug 2018 06:19:09 +0000 (08:19 +0200)
committerBenjamin Gaignard <benjamin.gaignard@linaro.org>
Tue, 7 Aug 2018 13:33:00 +0000 (15:33 +0200)
commitb0b9691f49f07bb0aff21a7e2e3bd2f3f62c7eb4
tree5c458116689572faf1b9fcfeaf5e04955d4d350b
parent7b92c79a7c302674b9bb2d99e9468f24ffa6bafb
drm/sti: do not remove the drm_bridge that was never added

Removing the drm_bridge_remove call should avoid a NULL dereference
during list processing in drm_bridge_remove if the error path is ever
taken.

The more natural approach would perhaps be to add a drm_bridge_add,
but there are several other bridges that never call drm_bridge_add.
Just removing the drm_bridge_remove is the easier fix.

Fixes: f521a57c0911 ("drm: sti: rework init sequence")
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20180806061910.29914-2-peda@axentia.se
drivers/gpu/drm/sti/sti_hda.c
drivers/gpu/drm/sti/sti_hdmi.c