]> git.baikalelectronics.ru Git - kernel.git/commit
serial: 8250_dw: Avoid pslverr on reading empty receiver fifo
authorVAMSHI GAJJELA <vamshigajjela@google.com>
Wed, 13 Jul 2022 13:17:22 +0000 (18:47 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Jul 2022 14:33:35 +0000 (16:33 +0200)
commitb0a8bb7d70af1c597bcc1ae17823d1d285a7ad86
tree07a47eb7b929e02067f664c4d3ad281bcbaca776
parent7f2c02693b86e8441461354046f8fcf7fdbb0900
serial: 8250_dw: Avoid pslverr on reading empty receiver fifo

With PSLVERR_RESP_EN parameter set to 1, the device generates an error
response when an attempt to read an empty RBR with FIFO enabled.

This happens when LCR writes are ignored when UART is busy.
dw8250_check_lcr() in retries to update LCR, invokes dw8250_force_idle()
to clear and reset FIFO and eventually reads UART_RX causing the error.

Avoid this by not reading RBR/UART_RX when no data is available.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: VAMSHI GAJJELA <vamshigajjela@google.com>
Link: https://lore.kernel.org/r/20220713131722.2316829-1-vamshigajjela@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_dw.c