]> git.baikalelectronics.ru Git - kernel.git/commit
net/core: revert "net: fix __netdev_update_features return.." and add comment
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Tue, 17 Nov 2015 14:49:06 +0000 (15:49 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Nov 2015 20:25:45 +0000 (15:25 -0500)
commitb07354502d6a138c19ed6774926533a916198b08
tree7234f1e9f3a38dff362a6efc9f775757ad9c5849
parent7aed4c1865390e5537ff7d13bf5695913ce1af77
net/core: revert "net: fix __netdev_update_features return.." and add comment

This reverts commit 36204e334087 ("net: fix __netdev_update_features return
on ndo_set_features failure")
and adds a comment explaining why it's okay to return a value other than
0 upon error. Some drivers might actually change flags and return an
error so it's better to fire a spurious notification rather than miss
these.

CC: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c