]> git.baikalelectronics.ru Git - kernel.git/commit
nbd: fix possible overflow on 'first_minor' in nbd_dev_add()
authorZhang Wensheng <zhangwensheng5@huawei.com>
Sat, 21 May 2022 07:37:48 +0000 (15:37 +0800)
committerJens Axboe <axboe@kernel.dk>
Sat, 28 May 2022 02:39:33 +0000 (20:39 -0600)
commitb0076d63e0624c88ae440fc7741f42b6e4d08268
treed085e4f3e4577942f7aa6d9f823a0a8567fad6c0
parentda7ee549773371fb97ba0b598535f77409ccb3a2
nbd: fix possible overflow on 'first_minor' in nbd_dev_add()

When 'index' is a big numbers, it may become negative which forced
to 'int'. then 'index << part_shift' might overflow to a positive
value that is not greater than '0xfffff', then sysfs might complains
about duplicate creation. Because of this, move the 'index' judgment
to the front will fix it and be better.

Fixes: 3d709b092efb ("nbd: use an idr to keep track of nbd devices")
Fixes: 759c2f288f48 ("nbd: fix possible overflow for 'first_minor' in nbd_dev_add()")
Signed-off-by: Zhang Wensheng <zhangwensheng5@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Link: https://lore.kernel.org/r/20220521073749.3146892-6-yukuai3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/nbd.c