]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: nf_tables: move base hook annotation to init helper
authorFlorian Westphal <fw@strlen.de>
Tue, 8 Jun 2021 21:06:07 +0000 (23:06 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 9 Jun 2021 19:29:23 +0000 (21:29 +0200)
commitaff5787191aae6707e08b6737c30d47e5af6b91d
tree3634d26b4cd6d240a59c63784d194c0166f05dff
parent6282fa1659d2acf3c6047b10361279512c23b233
netfilter: nf_tables: move base hook annotation to init helper

coverity scanner says:
2187  if (nft_is_base_chain(chain)) {
vvv   CID 1505166:  Memory - corruptions  (UNINIT)
vvv   Using uninitialized value "basechain".
2188  basechain->ops.hook_ops_type = NF_HOOK_OP_NF_TABLES;

... I don't see how nft_is_base_chain() can evaluate to true
while basechain pointer is garbage.

However, it seems better to place the NF_HOOK_OP_NF_TABLES annotation
in nft_basechain_hook_init() instead.

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1505166 ("Memory - corruptions")
Fixes: 65b8b7bfc5284f ("netfilter: annotate nf_tables base hook ops")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c