]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: crystalcove: Free IRQ on error path
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 28 Jul 2020 12:55:03 +0000 (15:55 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 3 Aug 2020 23:25:02 +0000 (01:25 +0200)
commitafac17b7d3fa025a2dd63f257e4cb260042aac33
tree72a7e397a669c89400b6173b7e94a1ddea698915
parentf67f97f17fa972504787718d706af7679b2c9b7b
gpio: crystalcove: Free IRQ on error path

It appears that all, but request_irq(), calls in the driver are device managed.
In unlikely case of devm_gpiochip_add_data() failure the IRQ left requested.
Free IRQ on error path by switching to devm_request_threaded_irq() API.

Byproduct of this change is a drop of ->remove() callback completely.

Fixes: 9b022a95c911 ("gpio: crystalcove: Use irqchip template")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200728125504.27786-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-crystalcove.c