]> git.baikalelectronics.ru Git - kernel.git/commit
net: ethernet: aeroflex: fix UAF in greth_of_remove
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 18 Jun 2021 14:57:31 +0000 (17:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 19 Jun 2021 18:45:10 +0000 (11:45 -0700)
commitaf82120a7c07f5663822e9f9857ffd375bbd28ca
tree9e2d776ac1c45651fab21d1e238ca17320c1e142
parent0aa4e57e72a771bb7e0bf199bd6b4568193a1f0b
net: ethernet: aeroflex: fix UAF in greth_of_remove

static int greth_of_remove(struct platform_device *of_dev)
{
...
struct greth_private *greth = netdev_priv(ndev);
...
unregister_netdev(ndev);
free_netdev(ndev);

of_iounmap(&of_dev->resource[0], greth->regs, resource_size(&of_dev->resource[0]));
...
}

greth is netdev private data, but it is used
after free_netdev(). It can cause use-after-free when accessing greth
pointer. So, fix it by moving free_netdev() after of_iounmap()
call.

Fixes: 7c2a0febc262 ("net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aeroflex/greth.c