]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: fix e2fsprogs checksum failure for mounted filesystem
authorJan Kara <jack@suse.cz>
Thu, 12 Aug 2021 12:47:37 +0000 (14:47 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 31 Aug 2021 03:36:50 +0000 (23:36 -0400)
commitaf6698a91491046ce8332007030441712c8ac0eb
tree4c20fb5ecbd4ba370100ca42cf202850b1ed5644
parent87cb98d718b683d4e36ec700329a6305b4cc8c5c
ext4: fix e2fsprogs checksum failure for mounted filesystem

Commit efb25fdda03 ("ext4: remove redundant sb checksum
recomputation") removed checksum recalculation after updating
superblock free space / inode counters in ext4_fill_super() based on
the fact that we will recalculate the checksum on superblock
writeout.

That is correct assumption but until the writeout happens (which can
take a long time) the checksum is incorrect in the buffer cache and if
programs such as tune2fs or resize2fs is called shortly after a file
system is mounted can fail.  So return back the checksum recalculation
and add a comment explaining why.

Fixes: efb25fdda032 ("ext4: remove redundant sb checksum recomputation")
Cc: stable@kernel.org
Reported-by: Boyang Xue <bxue@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Link: https://lore.kernel.org/r/20210812124737.21981-1-jack@suse.cz
fs/ext4/super.c