]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: seq: oss: Don't drain at closing a client
authorTakashi Iwai <tiwai@suse.de>
Tue, 1 Mar 2016 17:30:18 +0000 (18:30 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 1 Mar 2016 19:26:40 +0000 (20:26 +0100)
commitaf63d7371be3568d776518fd0cee54142f2d3b75
treeffff214617db5a0e674aa44dea139e37cfc980ad
parent96a5959580309448d5d91d03d9d7866ef7e63b7a
ALSA: seq: oss: Don't drain at closing a client

The OSS sequencer client tries to drain the pending events at
releasing.  Unfortunately, as spotted by syzkaller fuzzer, this may
lead to an unkillable process state when the event has been queued at
the far future.  Since the process being released can't be signaled
any longer, it remains and waits for the echo-back event in that far
future.

Back to history, the draining feature was implemented at the time we
misinterpreted POSIX definition for blocking file operation.
Actually, such a behavior is superfluous at release, and we should
just release the device as is instead of keeping it up forever.

This patch just removes the draining call that may block the release
for too long time unexpectedly.

BugLink: http://lkml.kernel.org/r/CACT4Y+Y4kD-aBGj37rf-xBw9bH3GMU6P+MYg4W1e-s-paVD2pg@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/oss/seq_oss.c
sound/core/seq/oss/seq_oss_device.h
sound/core/seq/oss/seq_oss_init.c