]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: mmc_spi: fix error handling in mmc_spi_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 31 Jan 2023 01:38:35 +0000 (09:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:59:48 +0000 (12:59 +0100)
commitaebdda79c1b73b1be57d35c4f500d01fccc32dab
treed4f627adffe3d0b3e84667ef761cc51b6f1c9397
parent5dbbfe1449449ccc2a6d20eb7a960e913baa69d6
mmc: mmc_spi: fix error handling in mmc_spi_probe()

commit 4468e17a6f92c17e8b29ec6134ce6fc14c8df28a upstream.

If mmc_add_host() fails, it doesn't need to call mmc_remove_host(),
or it will cause null-ptr-deref, because of deleting a not added
device in mmc_remove_host().

To fix this, goto label 'fail_glue_init', if mmc_add_host() fails,
and change the label 'fail_add_host' to 'fail_gpiod_request'.

Fixes: 00c60bb3c690 ("mmc_spi host driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Cc:stable@vger.kernel.org
Link: https://lore.kernel.org/r/20230131013835.3564011-1-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/host/mmc_spi.c