]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amdgpu/display: only enable aux backlight control for OLED panels
authorAlex Deucher <alexander.deucher@amd.com>
Wed, 21 Jul 2021 22:11:51 +0000 (18:11 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 28 Jul 2021 20:37:18 +0000 (16:37 -0400)
commitae574196ef79bc40afad6bf745dab6c19643e830
tree89aba3298652f618a27ea6e73a2e21471c1ca78f
parentdfef4f1964e27c5ac881434a69cda56f07da4361
drm/amdgpu/display: only enable aux backlight control for OLED panels

We've gotten a number of reports about backlight control not
working on panels which indicate that they use aux backlight
control.  A recent patch:

commit 6605796bfa6bc20cf6265f1725dd49b3ba4a0d62
Author: Camille Cho <Camille.Cho@amd.com>
Date:   Thu Jul 8 18:28:37 2021 +0800

    drm/amd/display: Only set default brightness for OLED

    [Why]
    We used to unconditionally set backlight path as AUX for panels capable
    of backlight adjustment via DPCD in set default brightness.

    [How]
    This should be limited to OLED panel only since we control backlight via
    PWM path for SDR mode in LCD HDR panel.

Reviewed-by: Krunoslav Kovac <krunoslav.kovac@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Camille Cho <Camille.Cho@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Changes some other code to only use aux for backlight control on
OLED panels.  The commit message seems to indicate that PWM should
be used for SDR mode on HDR panels.  Do something similar for
backlight control in general.  This may need to be revisited if and
when HDR started to get used.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1438
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=213715
Reviewed-by: Roman Li <Roman.Li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c