]> git.baikalelectronics.ru Git - kernel.git/commit
brcmfmac: fix memory leakage in msgbuf
authorArend van Spriel <arend@broadcom.com>
Thu, 7 Aug 2014 12:45:09 +0000 (14:45 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 11 Aug 2014 18:43:51 +0000 (14:43 -0400)
commitae2b83a47d29acf0a735bd2246bb8d6f13986605
tree360d48be9352651dac43b86526e5c3a6c7325390
parent263c47e6c8cc45f8494b939923328a446f64da12
brcmfmac: fix memory leakage in msgbuf

The kbuild robot came up with the following warning:

tree:   .../kernel/git/linville/wireless-next.git master
head:   1a9cf112de2f2d59b375ded0e6dc98067e357d91
commit: 1c189dc8aa72bd1a1bc69bb0d8fe30b441e81b40
 [5/13] brcmfmac: Adding msgbuf protocol.

coccinelle warnings:
 drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c:1309:1-28:
   alloc with no test, possible model on line 1318

Looking into the issue, it turned out that the referred allocation
buffer was not being released in failure path nor upon module
unload.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Daniel (Deognyoun) Kim <dekim@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c