]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: dmatest: warn user when dma test times out
authorAdam Wallis <awallis@codeaurora.org>
Thu, 2 Nov 2017 12:53:30 +0000 (08:53 -0400)
committerVinod Koul <vinod.koul@intel.com>
Wed, 8 Nov 2017 05:54:03 +0000 (11:24 +0530)
commitadc63360c422a2f2f8f67a4572fa70460d1fd013
treea95f59f344651c4fc63f744bee848103d1a14723
parent384fde7ed224f283f11ef2a592b05d4a29492aa8
dmaengine: dmatest: warn user when dma test times out

Commit 25dbfef30d03 ("dmatest: don't use set_freezable_with_signal()")
introduced a bug (that is in fact documented by the patch commit text)
that leaves behind a dangling pointer. Since the done_wait structure is
allocated on the stack, future invocations to the DMATEST can produce
undesirable results (e.g., corrupted spinlocks). Ideally, this would be
cleaned up in the thread handler, but at the very least, the kernel
is left in a very precarious scenario that can lead to some long debug
sessions when the crash comes later.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197605
Signed-off-by: Adam Wallis <awallis@codeaurora.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/dmatest.c