]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: toshsd: fix return value check of mmc_add_host()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 1 Nov 2022 06:30:21 +0000 (14:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:24 +0000 (13:32 +0100)
commitada9b355379198dfb5b9f1e99fb3d72e01295ec7
tree1efdd521e9874a0b3c375814008c65823158328b
parentfcc16f99714c2d8d525a92a56c94b07e4053cb30
mmc: toshsd: fix return value check of mmc_add_host()

[ Upstream commit 3957eab7a5f6ac3f85e70bee3530f22e48db6f27 ]

mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and goto error path which will call
mmc_free_host(), besides, free_irq() also needs be called.

Fixes: ce3a923dbf55 ("mmc: add Toshiba PCI SD controller driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-8-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/toshsd.c