]> git.baikalelectronics.ru Git - kernel.git/commit
tpm-dev-common: Reject too short writes
authorAlexander Steffen <Alexander.Steffen@infineon.com>
Fri, 8 Sep 2017 15:21:32 +0000 (17:21 +0200)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Wed, 18 Oct 2017 15:28:47 +0000 (18:28 +0300)
commitad93572c832134f965bcc57b61cf4c48a1404b26
tree93a16d26538c5525a32fe11279a812115bad2a1d
parent09c4720e9af0f0f67a36b64995b8ecb8dd105314
tpm-dev-common: Reject too short writes

tpm_transmit() does not offer an explicit interface to indicate the number
of valid bytes in the communication buffer. Instead, it relies on the
commandSize field in the TPM header that is encoded within the buffer.
Therefore, ensure that a) enough data has been written to the buffer, so
that the commandSize field is present and b) the commandSize field does not
announce more data than has been written to the buffer.

This should have been fixed with CVE-2011-1161 long ago, but apparently
a correct version of that patch never made it into the kernel.

Cc: stable@vger.kernel.org
Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm-dev-common.c