]> git.baikalelectronics.ru Git - kernel.git/commit
flowcache: Fix kernel panic in flow_cache_flush_task
authorMiroslav Urbanek <mu@miroslavurbanek.com>
Thu, 5 Feb 2015 15:36:50 +0000 (16:36 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Feb 2015 22:38:53 +0000 (14:38 -0800)
commitad82dc4cc32d0a628426965b623233c795fe1398
tree4fa6a03001136123b52f522ed22778f6f36ad28e
parentecd10ed0e26234d454ba2da4bfe1f872ff6d308f
flowcache: Fix kernel panic in flow_cache_flush_task

flow_cache_flush_task references a structure member flow_cache_gc_work
where it should reference flow_cache_flush_task instead.

Kernel panic occurs on kernels using IPsec during XFRM garbage
collection. The garbage collection interval can be shortened using the
following sysctl settings:

net.ipv4.xfrm4_gc_thresh=4
net.ipv6.xfrm6_gc_thresh=4

With the default settings, our productions servers crash approximately
once a week. With the settings above, they crash immediately.

Fixes: f87ce316a7a3 ("flowcache: Make flow cache name space aware")
Reported-by: Tomáš Charvát <tc@excello.cz>
Tested-by: Jan Hejl <jh@excello.cz>
Signed-off-by: Miroslav Urbanek <mu@miroslavurbanek.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/flow.c