]> git.baikalelectronics.ru Git - kernel.git/commit
ice: do not abort devlink info if board identifier can't be found
authorJacob Keller <jacob.e.keller@intel.com>
Thu, 19 Aug 2021 22:34:51 +0000 (15:34 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 20 Aug 2021 01:20:01 +0000 (18:20 -0700)
commitad503a8ed7d4097850f41b505242f92ef09c8eb3
tree1e7feaf960b09e41b599df03d7382866213d4b01
parent3f4828a4550c213fa8b600f095dae86ca65c0766
ice: do not abort devlink info if board identifier can't be found

The devlink dev info command reports version information about the
device and firmware running on the board. This includes the "board.id"
field which is supposed to represent an identifier of the board design.
The ice driver uses the Product Board Assembly identifier for this.

In some cases, the PBA is not present in the NVM. If this happens,
devlink dev info will fail with an error. Instead, modify the
ice_info_pba function to just exit without filling in the context
buffer. This will cause the board.id field to be skipped. Log a dev_dbg
message in case someone wants to confirm why board.id is not showing up
for them.

Fixes: f50f20549f94 ("ice: add board identifier info to devlink .info_get")
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://lore.kernel.org/r/20210819223451.245613-1-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ice/ice_devlink.c