]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: target: core: Add CONTROL field for trace events
authorRoman Bolshakov <r.bolshakov@yadro.com>
Tue, 29 Sep 2020 12:59:57 +0000 (15:59 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 2 Oct 2020 22:36:19 +0000 (18:36 -0400)
commitad23530b69069785826af73ff6b2dd953c31939a
tree1aa8b7c6edb70f55248c075d2191fdb265763c6a
parentc448e8d3082fe84e164307a7856aca91563a20d8
scsi: target: core: Add CONTROL field for trace events

trace-cmd report doesn't show events from target subsystem because
scsi_command_size() leaks through event format string:

  [target:target_sequencer_start] function scsi_command_size not defined
  [target:target_cmd_complete] function scsi_command_size not defined

Addition of scsi_command_size() to plugin_scsi.c in trace-cmd doesn't
help because an expression is used inside TP_printk(). trace-cmd event
parser doesn't understand minus sign inside [ ]:

  Error: expected ']' but read '-'

Rather than duplicating kernel code in plugin_scsi.c, provide a dedicated
field for CONTROL byte.

Link: https://lore.kernel.org/r/20200929125957.83069-1-r.bolshakov@yadro.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
include/scsi/scsi_common.h
include/trace/events/target.h