]> git.baikalelectronics.ru Git - kernel.git/commit
ibmvnic: Fix possibly uninitialized old_num_tx_queues variable warning.
authorMichal Suchanek <msuchanek@suse.de>
Tue, 2 Mar 2021 19:47:47 +0000 (20:47 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 Mar 2021 16:46:24 +0000 (08:46 -0800)
commitacbab63a2b50704d636231631acaba8f70c6d0ca
treef211ed15a4860d601f47d07128955875bdffae94
parent574d9e89d19ec5878f0232f67a36e72595eb570c
ibmvnic: Fix possibly uninitialized old_num_tx_queues variable warning.

GCC 7.5 reports:
../drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset_init':
../drivers/net/ethernet/ibm/ibmvnic.c:5373:51: warning: 'old_num_tx_queues' may be used uninitialized in this function [-Wmaybe-uninitialized]
../drivers/net/ethernet/ibm/ibmvnic.c:5373:6: warning: 'old_num_rx_queues' may be used uninitialized in this function [-Wmaybe-uninitialized]

The variable is initialized only if(reset) and used only if(reset &&
something) so this is a false positive. However, there is no reason to
not initialize the variables unconditionally avoiding the warning.

Fixes: 763ee3ecb3a7 ("ibmvnic: merge ibmvnic_reset_init and ibmvnic_init")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c