]> git.baikalelectronics.ru Git - kernel.git/commit
tpm: tpm_ibm_vtpm: Fix unallocated banks
authorNayna Jain <nayna@linux.ibm.com>
Thu, 11 Jul 2019 16:13:35 +0000 (12:13 -0400)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Sun, 4 Aug 2019 21:55:00 +0000 (00:55 +0300)
commitacab6f0e04af7057cc875363021715d459005a66
treec66fea5ae2f288c438094918bdbaf79c26b06ed1
parentf1b2db24e71d456dca3ed3d56c076b3b011cdf3c
tpm: tpm_ibm_vtpm: Fix unallocated banks

The nr_allocated_banks and allocated banks are initialized as part of
tpm_chip_register. Currently, this is done as part of auto startup
function. However, some drivers, like the ibm vtpm driver, do not run
auto startup during initialization. This results in uninitialized memory
issue and causes a kernel panic during boot.

This patch moves the pcr allocation outside the auto startup function
into tpm_chip_register. This ensures that allocated banks are initialized
in any case.

Fixes: 4817e8bc9720 ("tpm: retrieve digest size of unknown algorithms with PCR read")
Reported-by: Michal Suchanek <msuchanek@suse.de>
Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
Tested-by: Michal Suchánek <msuchanek@suse.de>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm-chip.c
drivers/char/tpm/tpm.h
drivers/char/tpm/tpm1-cmd.c
drivers/char/tpm/tpm2-cmd.c