]> git.baikalelectronics.ru Git - kernel.git/commit
watchdog: sbsa: use 32-bit read for WCV
authorJayachandran C <jnair@caviumnetworks.com>
Wed, 28 Feb 2018 10:52:20 +0000 (02:52 -0800)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 3 Mar 2018 14:52:32 +0000 (15:52 +0100)
commitaca884247bcf3dab2937c7f121670211df6c110b
tree8c2778bf30f3104d9a2dfecb008e7cdcddf3e0b3
parent9fe457becb9ab72a608524ab257f8223cd09ccee
watchdog: sbsa: use 32-bit read for WCV

According to SBSA spec v3.1 section 5.3:
  All registers are 32 bits in size and should be accessed using
  32-bit reads and writes. If an access size other than 32 bits
  is used then the results are IMPLEMENTATION DEFINED.
  [...]
  The Generic Watchdog is little-endian

The current code uses readq to read the watchdog compare register
which does a 64-bit access. This fails on ThunderX2 which does not
implement 64-bit access to this register.

Fix this by using lo_hi_readq() that does two 32-bit reads.

Signed-off-by: Jayachandran C <jnair@caviumnetworks.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/sbsa_gwdt.c