]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: moxart: fix return value check of mmc_add_host()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 1 Nov 2022 06:30:16 +0000 (14:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:23 +0000 (13:32 +0100)
commitac60a88568c99217b48a93db4478f4a82cd38e3b
treee2b99a692f80017358d2658709e318bd97ecb99e
parent8fc3d3d5dfe3d610a4284cdb1596132417f1f37e
mmc: moxart: fix return value check of mmc_add_host()

[ Upstream commit a037712057a90335d64bd143cad875800cbcd3a6 ]

mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and goto error path which will call
mmc_free_host().

Fixes: 56a814228726 ("mmc: moxart: Add MOXA ART SD/MMC driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-3-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/moxart-mmc.c