]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: rcar: Fix use-after-free in probe error path
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 7 Dec 2017 10:15:19 +0000 (11:15 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 12 Dec 2017 17:01:47 +0000 (11:01 -0600)
commitabd2f7e4b132a4a9c4817333df963f718eeb1aa5
treee39aee603c3c12ad4600cec69431e0e4ab5f7746
parent27dcfdd83527629ad9cc38aa3902f41d8f3cea9a
PCI: rcar: Fix use-after-free in probe error path

If CONFIG_DEBUG_SLAB=y, and no PCIe card is inserted, the kernel crashes
during probe on r8a7791/koelsch:

  rcar-pcie fe000000.pcie: PCIe link down
  Unable to handle kernel paging request at virtual address 6b6b6b6b

(seeing this message requires earlycon and keep_bootcon).

Indeed, pci_free_host_bridge() frees the PCI host bridge, including the
embedded rcar_pcie object, so pci_free_resource_list() must not be called
afterwards.

To fix this, move the call to pci_free_resource_list() up, and update the
label name accordingly.

Fixes: e721b68b66c3f4ac ("PCI: rcar: Fix memory leak when no PCIe card is inserted")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/host/pcie-rcar.c