]> git.baikalelectronics.ru Git - kernel.git/commit
sched/fair: Fix CFS bandwidth hrtimer expiry type
authorOdin Ugedal <odin@uged.al>
Tue, 29 Jun 2021 12:14:52 +0000 (14:14 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 2 Jul 2021 13:58:24 +0000 (15:58 +0200)
commitab7980fb5425ccf1a7971b9a0262cb2c3aa86730
tree93567a1879448c91711ed8ff217a59c039403767
parent7c2ed48b98fd3e76d2e54991d8dd72d67a42adc4
sched/fair: Fix CFS bandwidth hrtimer expiry type

The time remaining until expiry of the refresh_timer can be negative.
Casting the type to an unsigned 64-bit value will cause integer
underflow, making the runtime_refresh_within return false instead of
true. These situations are rare, but they do happen.

This does not cause user-facing issues or errors; other than
possibly unthrottling cfs_rq's using runtime from the previous period(s),
making the CFS bandwidth enforcement less strict in those (special)
situations.

Signed-off-by: Odin Ugedal <odin@uged.al>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ben Segall <bsegall@google.com>
Link: https://lore.kernel.org/r/20210629121452.18429-1-odin@uged.al
kernel/sched/fair.c