]> git.baikalelectronics.ru Git - kernel.git/commit
net: sched: Allow statistics reads from softirq.
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tue, 19 Oct 2021 10:12:04 +0000 (12:12 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Oct 2021 12:07:35 +0000 (13:07 +0100)
commitab50d182305b8e5c174659d8b8d980e5678bd363
tree71470e97aab9eb973799c15ee5b9516983ac3ffc
parent55aa8bd70dcdf00ce91d82ae342d31ab4d0e6de5
net: sched: Allow statistics reads from softirq.

Eric reported that the rate estimator reads statics from the softirq
which in turn triggers a warning introduced in the statistics rework.

The warning is too cautious. The updates happen in the softirq context
so reads from softirq are fine since the writes can not be preempted.
The updates/writes happen during qdisc_run() which ensures one writer
and the softirq context.
The remaining bad context for reading statistics remains in hard-IRQ
because it may preempt a writer.

Fixes: 026a0cbf15c11 ("net: sched: Remove Qdisc::running sequence counter")
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/gen_stats.c