]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: hda/hdmi: Don't skip notification handling during PM operation
authorTakashi Iwai <tiwai@suse.de>
Sat, 1 Oct 2022 07:48:10 +0000 (09:48 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sat, 1 Oct 2022 07:50:37 +0000 (09:50 +0200)
commitab4ffc0485c75b51c68db8d8afa8692e0bbc9dd7
tree09a49af6bb8495be0bda10c5c9f6d36791bac9c6
parent6627e8a3758d1d481abfc7ae3e0548cec2aa78c3
ALSA: hda/hdmi: Don't skip notification handling during PM operation

The HDMI driver skips the notification handling from the graphics
driver when the codec driver is being in the PM operation.  This
behavior was introduced by the commit 73864a554941 ("ALSA: hda - Skip
ELD notification during PM process").  This skip may cause a problem,
as we may miss the ELD update when the connection/disconnection
happens right at the runtime-PM operation of the audio codec.

Although this workaround was valid at that time, it's no longer true;
the fix was required just because the ELD update procedure needed to
wake up the audio codec, which had lead to a runtime-resume during a
runtime-suspend.  Meanwhile, the ELD update procedure doesn't need a
codec wake up any longer since the commit 1e459ffe9770 ("ALSA: hda -
Use component ops for i915 HDMI/DP audio jack handling"); i.e. there
is no much reason for skipping the notification.

Let's drop those checks for addressing the missing notification.

Fixes: 1e459ffe9770 ("ALSA: hda - Use component ops for i915 HDMI/DP audio jack handling")
Reported-by: Brent Lu <brent.lu@intel.com>
Link: https://lore.kernel.org/r/20220927135807.4097052-1-brent.lu@intel.com
Link: https://lore.kernel.org/r/20221001074809.7461-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_hdmi.c