]> git.baikalelectronics.ru Git - kernel.git/commit
rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions
authorBoqun Feng <boqun.feng@gmail.com>
Wed, 7 Mar 2018 08:49:39 +0000 (16:49 +0800)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Tue, 15 May 2018 17:26:01 +0000 (10:26 -0700)
commitab33f1d799b816fee1e3875750303e80cf5708f4
tree25cd6760e384e2443a51b51c04c64fb55575a0ee
parentc712fa530f55ca51d05022ec6552991401db3b57
rcu: exp: Fix "must hold exp_mutex" comments for QS reporting functions

Since commit 0efc2d017868 ("rcu: Add expedited grace-period support
for preemptible RCU"), there are comments for some funtions in
rcu_report_exp_rnp()'s call-chain saying that exp_mutex or its
predecessors needs to be held.

However, exp_mutex and its predecessors were used only to synchronize
between GPs, and it is clear that all variables visited by those functions
are under the protection of rcu_node's ->lock. Moreover, those functions
are currently called without held exp_mutex, and seems that doesn't
introduce any trouble.

So this patch fixes this problem by updating the comments to match the
current code.

Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Fixes: 0efc2d017868 ("rcu: Add expedited grace-period support for preemptible RCU")
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Tested-by: Nicholas Piggin <npiggin@gmail.com>
kernel/rcu/tree_exp.h