]> git.baikalelectronics.ru Git - kernel.git/commit
net: qrtr: Avoid potential use after free in MHI send
authorBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 21 Apr 2021 17:40:07 +0000 (10:40 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Apr 2021 18:01:03 +0000 (11:01 -0700)
commitaac30725601c32bf6d7f3276a07142950e3d4c6a
treec66d2abce9babf4914ff97d2e3b20b8cd76023b1
parentd2c88a07cdf1f2df9d7a81140e1ee7a039d4d8fe
net: qrtr: Avoid potential use after free in MHI send

It is possible that the MHI ul_callback will be invoked immediately
following the queueing of the skb for transmission, leading to the
callback decrementing the refcount of the associated sk and freeing the
skb.

As such the dereference of skb and the increment of the sk refcount must
happen before the skb is queued, to avoid the skb to be used after free
and potentially the sk to drop its last refcount..

Fixes: b9c965775871 ("net: qrtr: Add MHI transport layer")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/qrtr/mhi.c