]> git.baikalelectronics.ru Git - kernel.git/commit
staging: bcm2835-camera: fix timeout handling in wait_for_completion_timeout
authorNicholas Mc Guire <hofrat@osadl.org>
Sat, 21 Jul 2018 13:20:28 +0000 (15:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jul 2018 12:00:54 +0000 (14:00 +0200)
commitaa6b43fe56871550f95c67fc86aec3e2c5f8ba86
treed79077f81b5c94d7157ce6944224ff9b9d9a64ff
parente764df0dcdddaa876adc94ca2b3d3a90025af834
staging: bcm2835-camera: fix timeout handling in wait_for_completion_timeout

wait_for_completion_timeout returns unsigned long not int so a variable of
proper type is introduced. Further the check for <= 0 is ambiguous and should
be == 0 here indicating timeout which is the only error case so no additional
check needed here.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: 1a5643cbb0e3 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c