]> git.baikalelectronics.ru Git - kernel.git/commit
net/tls: remove the dead inplace_crypto code
authorJakub Kicinski <jakub.kicinski@netronome.com>
Wed, 27 Nov 2019 20:16:43 +0000 (12:16 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Nov 2019 06:40:29 +0000 (22:40 -0800)
commitaa545a1103335870c821ea9bf0efd297a8bf1ef5
tree92fafe20cc6e67a73043b9bf46711e65934eda85
parent455b18c39bef0e37771bccb7ec58b946afeba256
net/tls: remove the dead inplace_crypto code

Looks like when BPF support was added by commit 635a8c9b3da8
("tls: add bpf support to sk_msg handling") and
commit 1a40c5d6e820 ("tls: convert to generic sk_msg interface")
it broke/removed the support for in-place crypto as added by
commit 8faeac9f15a7 ("tls: Add support for inplace records
encryption").

The inplace_crypto member of struct tls_rec is dead, inited
to zero, and sometimes set to zero again. It used to be
set to 1 when record was allocated, but the skmsg code doesn't
seem to have been written with the idea of in-place crypto
in mind.

Since non trivial effort is required to bring the feature back
and we don't really have the HW to measure the benefit just
remove the left over support for now to avoid confusing readers.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/tls.h
net/tls/tls_sw.c