]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"
authorJosé Expósito <jose.exposito89@gmail.com>
Fri, 1 Apr 2022 04:15:36 +0000 (21:15 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 1 Apr 2022 04:17:52 +0000 (21:17 -0700)
commitaa3c5c6b7c5d5cfc7ffd643baec713314ca6d105
tree1b512bac89b8b990df9fc23a40e8159a50c39e4e
parent919f03d7bd4a0a2258f46cf3a54c436b244747b0
Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"

This reverts commit 73fa349eb88d705c135d975780fb29d73615bc0f.

The touchpad present in the Dell Precision 7550 and 7750 laptops
reports a HID_DG_BUTTONTYPE of type MT_BUTTONTYPE_CLICKPAD. However,
the device is not a clickpad, it is a touchpad with physical buttons.

In order to fix this issue, a quirk for the device was introduced in
libinput [1] [2] to disable the INPUT_PROP_BUTTONPAD property:

[Precision 7x50 Touchpad]
MatchBus=i2c
MatchUdevType=touchpad
MatchDMIModalias=dmi:*svnDellInc.:pnPrecision7?50*
AttrInputPropDisable=INPUT_PROP_BUTTONPAD

However, because of the change introduced in 73fa349eb8 ("Input: clear
BTN_RIGHT/MIDDLE on buttonpads") the BTN_RIGHT key bit is not mapped
anymore breaking the device right click button and making impossible to
workaround it in user space.

In order to avoid breakage on other present or future devices, revert
the patch causing the issue.

Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220321184404.20025-1-jose.exposito89@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/input.c