]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Remove redundant state verification during TypeC AUX power well disabling
authorImre Deak <imre.deak@intel.com>
Tue, 22 Feb 2022 16:51:32 +0000 (18:51 +0200)
committerImre Deak <imre.deak@intel.com>
Mon, 28 Feb 2022 15:03:32 +0000 (17:03 +0200)
commitaa3157ad5f3ffd67c8a6aef53d3ee3ae81646a72
tree46695d7dd0fbe99209143a7df09d85b20ec53ced
parent8d8be329ba72b2c29e31e52c23648c2e88dd0f7e
drm/i915: Remove redundant state verification during TypeC AUX power well disabling

Commit f5f3c2a8c0b085
("drm/i915: Add state verification for the TypeC port mode")
added a verification to the TypeC AUX power well enable()/disable()
hooks to check if the TypeC port related to this power well is properly
locked. If the disabling happens asynchronously the verification is
skipped, since in this case the port is unlocked. The detection of
asnychronous disabling doesn't work as intended though, since the power
well's reference count is always 0 when its disable() hook is called
(and since there won't be any domain reference held for this power well
either, the verification is always skipped); remove the verification
from the disable() hook for now. In the power well's enable() hook the
power well's reference will be always >0 and there won't be any
asynchronous disabling pending for it, so we can drop the async refcount
check from there.

No functional change.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220222165137.1004194-4-imre.deak@intel.com
drivers/gpu/drm/i915/display/intel_display_power.c