]> git.baikalelectronics.ru Git - kernel.git/commit
amd-xgbe: fix the SFP compliance codes check for DAC cables
authorRaju Rangoju <Raju.Rangoju@amd.com>
Thu, 20 Oct 2022 06:42:14 +0000 (12:12 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Nov 2022 14:56:55 +0000 (23:56 +0900)
commitaa14a5c96b632036fd5d58961d15db5a6f382670
tree84afce3afa737fb8e18d2e0a39f1a129772751a1
parent4ca7882e8617f5129f898f7eee2cc8188d1ecd1a
amd-xgbe: fix the SFP compliance codes check for DAC cables

[ Upstream commit 4911d841b15dd51781008eb36479f7ff889eb069 ]

The current XGBE code assumes that offset 6 of EEPROM SFP DAC (passive)
cables is NULL. However, some cables (the 5 meter and 7 meter Molex
passive cables) have non-zero data at offset 6. Fix the logic by moving
the passive cable check above the active checks, so as not to be
improperly identified as an active cable. This will fix the issue for
any passive cable that advertises 1000Base-CX in offset 6.

Fixes: b4e904b9c76f ("amd-xgbe: Add support for SFP+ modules")
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c