]> git.baikalelectronics.ru Git - kernel.git/commit
isdn: Partially revert debug format string usage clean up
authorChristoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de>
Wed, 25 Nov 2015 06:47:40 +0000 (07:47 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Nov 2015 16:49:58 +0000 (11:49 -0500)
commitaa10be37caaff4272e4b8731dbc0ea7ddfae9719
tree41f8d634a7c0ea779bd199c75c36a776da018296
parentf12acab822d28a6b8cbb738b89d033096558a305
isdn: Partially revert debug format string usage clean up

Commit 8ec83b9 ("isdn: clean up debug format string usage") introduced
a safeguard to avoid accidential format string interpolation of data
when calling debugl1 or HiSax_putstatus. This did however not take into
account VHiSax_putstatus (called by HiSax_putstatus) does *not* call
vsprintf if the head parameter is NULL - the format string is treated
as plain text then instead. As a result, the string "%s" is processed
literally, and the actual information is lost. This affects the isdnlog
userspace program which stopped logging information since that commit.

So revert the HiSax_putstatus invocations to the previous state.

Fixes: 8ec83b917c0d ("isdn: clean up debug format string usage")
Cc: Kees Cook <keescook@chromium.org>
Cc: Karsten Keil <isdn@linux-pingi.de>
Signed-off-by: Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/config.c
drivers/isdn/hisax/hfc_pci.c
drivers/isdn/hisax/hfc_sx.c
drivers/isdn/hisax/q931.c