]> git.baikalelectronics.ru Git - kernel.git/commit
netlink: Fix dump skb leak/double free
authorHerbert Xu <herbert@gondor.apana.org.au>
Mon, 16 May 2016 09:28:16 +0000 (17:28 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 May 2016 02:05:15 +0000 (22:05 -0400)
commitaa0731ad108cc8f4a928b5fa1862fba0c17a9a62
tree4fdcb3313923315bb1d2065bbf1c2b522d8854b5
parent37482caa3bca3b3092517adad035e8abf4e69d70
netlink: Fix dump skb leak/double free

When we free cb->skb after a dump, we do it after releasing the
lock.  This means that a new dump could have started in the time
being and we'll end up freeing their skb instead of ours.

This patch saves the skb and module before we unlock so we free
the right memory.

Fixes: abb6cd1d1e1d ("netlink: Eliminate kmalloc in netlink dump operation.")
Reported-by: Baozeng Ding <sploving1@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c