]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl-tegra: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 21 Dec 2015 16:39:44 +0000 (17:39 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 22 Dec 2015 12:44:00 +0000 (13:44 +0100)
commita9c63e2e2eda7669b1817bb78d8792a612032a72
tree3cdd2d99e0fa1067a1873287662590fc92f575d8
parent446dcc766d5cb49dd75bfa6eaa1ff2674faaa0b3
pinctrl-tegra: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a
return from the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e,e1;
@@

 for_each_child_of_node(e1,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-tegra-xusb.c
drivers/pinctrl/pinctrl-tegra.c