]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: fix possible RPM ref leaking during RPS disabling
authorImre Deak <imre.deak@intel.com>
Mon, 12 May 2014 15:35:04 +0000 (18:35 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 22 May 2014 19:53:11 +0000 (21:53 +0200)
commita9b0d83fe0caef7d0d38e79b1ed0b1c1f95ecdf0
tree4cc9105492870c92374a2e2b8b05a3a76963981b
parent04d2199c4c5637a24f67ad6ccb9a02d7e0326266
drm/i915: fix possible RPM ref leaking during RPS disabling

In

commit 53a3f0fc51ac8bbb334496f159dbc4284280b9d9
Author: Imre Deak <imre.deak@intel.com>
Date:   Mon Apr 14 20:24:29 2014 +0300

    drm/i915: get a runtime PM ref for the deferred GT powersave enabling

I added an RPM get-ref when enabling RPS from a deferred work, but forgot
to add the corresponding put-ref when canceling the work. This may leave
RPM disabled.

Note that the race is real since we run the rps enabling with a
delayed work item after resume, so leaves enough time (in contrived
examples) to fit a quick autoresum in.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Robert Beckett <robert.beckett@intel.com>
Testecase: igt/pm_rpm/system-suspend
[danvet: Mention testcase and add note.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_pm.c