]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/breadcrumbs: Drop assertion that we've already enabled irqs
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 17 Jan 2019 23:31:26 +0000 (23:31 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 18 Jan 2019 08:30:40 +0000 (08:30 +0000)
commita9a55aad3e28fce69388d747d7f7d3140b4ac81c
treef4be3abde1ef491e766b48489e7aa700958bd044
parentc4907d86d3a3b88acaab12ab5977d21ddd315760
drm/i915/breadcrumbs: Drop assertion that we've already enabled irqs

The motivation for introducing the check that we only enable breadcrumb
irqs if the device's irq was installed was once upon a time we waited
during suspend after disabling interrupts (which was quite slow until
the bug was discovered). Since then we have the notion of pinning the
breadcrumb irq, broadening it from the sole purpose of user interrupt
notification and waiting, and more importantly decoupling it from a very
defined time period during which enabling the irq was expected. So stop
insisting the irq is installed before we setup our IMR masks, if the IER
isn't yet enabled, nothing will happen and we will timeout instead,
revealing the lack of irq in the hang debug messages.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190117233126.30165-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_breadcrumbs.c